microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.73k stars 29.09k forks source link

Search UI in file can block a result. #73619

Closed cfjedimaster closed 5 years ago

cfjedimaster commented 5 years ago

Issue Type: Bug

This is pretty rare, but imagine you have a file open and are looking for X. There are 2 results. As you navigate through them, you can see result 2, but not the first. Why?

The first match is on line one towards the right of the editor pane and is covered by the file UI itself.

Now that I know it happened I'll know to look for it in the future, but it's still something that maybe the UI could handle better.

VS Code version: Code - Insiders 1.34.20-insider (57b550c559b945eb9d871dbf2b2e4cb9e31e2551, 2019-05-10T17:36:45.765Z) OS version: Windows_NT x64 10.0.18362

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2112)| |GPU Status|2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled| |Load (avg)|undefined| |Memory (System)|15.93GB (1.14GB free)| |Process Argv|| |Screen Reader|no| |VM|0%|
Extensions (28) Extension|Author (truncated)|Version ---|---|--- spellright|ban|3.0.38 markdown-preview-github-styles|bie|0.1.6 better-toml|bun|0.3.2 simple-timer|bur|1.0.1 npm-intellisense|chr|1.3.0 path-intellisense|chr|1.4.2 vscode-eslint|dba|1.8.2 tslint|eg2|1.0.43 vscode-npm-script|eg2|0.3.7 vscode-great-icons|emm|2.1.47 coldfusion|ili|1.0.1 search-node-modules|jas|1.3.0 vscode-sshfs|Kel|1.16.2 wordcounter|kir|1.6.0 dotenv|mik|1.0.1 vetur|oct|0.20.0 material-icon-theme|PKi|3.7.0 polacode|pnp|0.3.2 htmlescape-vscode-extension|ray|0.0.6 java|red|0.44.0 nativescript|Tel|0.10.0 vscodeintellicode|Vis|1.1.6 vscode-java-debug|vsc|0.18.0 vscode-java-dependency|vsc|0.4.0 vscode-java-pack|vsc|0.7.1 vscode-maven|vsc|0.16.2 nodejs-extension-pack|wad|0.1.9 JavaScriptSnippets|xab|1.7.2 (1 theme extensions excluded)
rebornix commented 5 years ago

We fail to reveal the find result when it's being covered by the find widget.

vscodebot[bot] commented 5 years ago

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!