microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.23k stars 29.29k forks source link

keybindgs.json "key" does not tolerate spaces #7645

Closed isidorn closed 3 years ago

isidorn commented 8 years ago

Open keybindgs.json and have the following keybinding { "key": "cmd + d", "command": "editor.action.deleteLines", "when": "editorTextFocus" },

Notice the space around the + in "key". Due to that this keybinding does not get registered. I would expect that the spaces around the + get ignored.

alexdima commented 3 years ago

Given we now have the keybindings editor and manually writing these keybindings is less likely, I would not relax the parsing rules now, so to not confuse with chords e.g. cmd d is different than cmd + d