search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.62k stars 29.03k forks source link

Color profiles other than sRGB cause major performance issues #78326

Closed farski closed 10 months ago

farski commented 5 years ago

Issue Type: Performance Issue

Performance of the buffer is severly degraded when the system color profile is set to anything other than sRGB. I believe this is related to an underlying issue with Chromium (821020, 791828, 989904). There is a workaround in some other Chromium-based apps (e.g., Chrome), which allow the profile off the app to be distinct from the system profile. I have not been able to figure out a way to provide such an override with VS Code. Until the issue with Chromium is fixed, having the ability to set the color profile specifically for VS Code would be extermely helpful.

VS Code version: Code 1.36.1 (2213894ea0415ee8c85c5eea0d0ff81ecc191529, 2019-07-08T22:56:38.504Z) OS version: Darwin x64 18.7.0

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i5-4288U CPU @ 2.60GHz (4 x 2600)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_deferred_display_list: disabled_off
skia_renderer: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|2, 2, 3| |Memory (System)|16.00GB (1.94GB free)| |Process Argv|| |Screen Reader|no| |VM|0%|
Process Info ``` CPU % Mem MB PID Process 14 131 69877 code main 0 82 69878 gpu-process 0 197 69880 window (radiotopia.fm-hosted_zone.yml — Infrastructure) 0 82 69980 extensionHost 0 49 69981 watcherService 0 98 69982 shared-process 0 0 70086 /bin/ps -ax -o pid=,ppid=,pcpu=,pmem=,command= 0 82 70084 window (Issue Reporter) ```
Workspace Info ``` | Window (radiotopia.fm-hosted_zone.yml — Infrastructure) | Folder (Infrastructure): 133 files | File types: yml(79) py(15) md(11) js(11) DS_Store(7) sh(3) json(3) | yaml(1) gitignore(1) xml(1) | Conf files:; ```

Extensions: none

bpasero commented 5 years ago

We are building exploration builds that use a much newer version of our UI framework (Electron version 6.0.x). I wonder if this issue reproduces with one of these builds, could you try? Download:

farski commented 5 years ago

I will give it a shot. FWIW this issue is now being tracked in the Chromium project, and seems like it needs to be fixed there, so if the new version of Electron is still using that, it is likely impacted.

bpasero commented 5 years ago

Thanks

vscodebot[bot] commented 5 years ago

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

farski commented 5 years ago

@bpasero I've confirmed that this issue still occurs with the exploration build.

bpasero commented 5 years ago

I think this will be fixed with E6.

farski commented 5 years ago

The root cause in Chromium still hasn't been identified. Is there a change in E6 that will workaround the problem?

bpasero commented 5 years ago

Oh sorry, I did not see the linked issue. Thanks for doing that!

deepak1556 commented 10 months ago

Closing as upstream marked the issue as wont fix, please check if the issue is present with latest stable.