microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.73k stars 29.09k forks source link

Accessibility: macOS Native tabs #79920

Closed rcarmo closed 5 years ago

rcarmo commented 5 years ago

Issue Type: Bug

I am running the latest prod build on Mojave and require native tabs to work so that I can use a macOS Accessibility extension to enumerate individual editor tabs and switch to them.

However, native tabs create separate workspaces and not individual, per-file editors. I've reviewed #76537, #77047 and other similar issues and none seem to mention accessibility requirements, but one of the points of having native Cocoa tab support is, indeed, allowing screen readers and other tools to work seamlessly on the platform.

VS Code version: Code 1.37.1 (f06011ac164ae4dc8e753a3fe7f9549844d15e35, 2019-08-15T16:16:34.800Z) OS version: Darwin x64 18.7.0

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i5-7500 CPU @ 3.40GHz (4 x 3400)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_deferred_display_list: disabled_off
skia_renderer: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|3, 3, 2| |Memory (System)|8.00GB (0.24GB free)| |Process Argv|| |Screen Reader|no| |VM|0%|
Extensions (33) Extension|Author (truncated)|Version ---|---|--- amvim|aui|1.30.0 spellright|ban|3.0.46 calva|bet|2.0.33 calva-fmt|cos|0.0.38 clojure4vscode|cos|1.3.71 paredit-revived|cos|0.1.22 vscode-markdownlint|Dav|0.30.1 gitlens|eam|9.9.3 Kotlin|mat|1.7.0 terraform|mau|1.4.0 vscode-azureappservice|ms-|0.15.0 vscode-azurefunctions|ms-|0.18.1 vscode-azurestorage|ms-|0.7.1 vscode-azureterraform|ms-|0.2.4 vscode-docker|ms-|0.7.0 vscode-kubernetes-tools|ms-|1.0.2 python|ms-|2019.8.30787 remote-containers|ms-|0.67.3 remote-ssh|ms-|0.45.6 remote-ssh-edit|ms-|0.45.6 remote-ssh-explorer|ms-|0.45.6 remote-wsl|ms-|0.39.2 vscode-remote-extensionpack|ms-|0.16.0 azure-account|ms-|0.8.4 cpptools|ms-|0.25.0 csharp|ms-|1.21.1 Go|ms-|0.11.4 azurerm-vscode-tools|msa|0.6.0 vscode-yaml|red|0.5.1 vscode-parinfer|sha|0.6.2 nativescript|Tel|0.10.1 clojure-warrior|ton|0.2.4 vscode-arduino|vsc|0.2.27
vscodebot[bot] commented 5 years ago

(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

isidorn commented 5 years ago

This looks like a duplicate of #76537 Though assigning to @deepak1556 to decide

deepak1556 commented 5 years ago

@rcarmo do you have Settings > Window: Native Tabs enabled ? Also can you try our exploration builds and see if the issue persists https://github.com/microsoft/vscode/pull/75802#issue-289924821. Thanks!

@isidorn the other issue is about native tabs not working with macOS sierra

rcarmo commented 5 years ago

Yes, of course :) I did my homework and read through a set of similar issues. My issue is about Mojave and individual native tabs per file.

I will try those builds and report back ASAP.

deepak1556 commented 5 years ago

@rcarmo where you able to give those builds a try ?

rcarmo commented 5 years ago

Once. The UX was not to my liking, to be honest, and the build wouldn’t load one of my extensions, so I moved on and installed Sublime on my Mac again.

vscodebot[bot] commented 5 years ago

We closed this issue because we are unable to reproduce the problem with the steps you describe. Chances are we've already fixed your problem in a recent version of VS Code. If not, please ask us to reopen the issue and provide us with more detail. Our issue reporting guidelines might help you with that.

Happy Coding!