search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.65k stars 29.05k forks source link

Selecting IntelliSense overwrites text instead of inserting #82358

Closed StickNitro closed 5 years ago

StickNitro commented 5 years ago

Issue Type: Bug

When selecting an entry from IntelliSense the text on the line after the caret is getting replaced

e.g. closing brackets or braces are replaced, or part of a closing HTML tag gets replaced.

See this video showing the problem

VS Code version: Code - Insiders 1.40.0-insider (72bc289d32ec4f867e73b7f1f2a22f7d614ae2bb, 2019-10-11T05:37:27.907Z) OS version: Darwin x64 19.0.0

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz (8 x 3100)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off
surface_control: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|3, 3, 3| |Memory (System)|16.00GB (0.63GB free)| |Process Argv|| |Screen Reader|no| |VM|0%|
Extensions (48) Extension|Author (truncated)|Version ---|---|--- user-secrets|adr|1.0.1 vscode-angular2-files|ale|1.6.2 sort-imports|ama|6.1.0 ng-template|Ang|0.802.3 markdown-preview-github-styles|bie|0.1.6 npm-intellisense|chr|1.3.0 path-intellisense|chr|1.4.2 bracket-pair-colorizer-2|Coe|0.0.28 githistory|don|0.4.6 xml|Dot|2.5.0 gitlens|eam|10.1.1 EditorConfig|Edi|0.14.1 vscode-npm-script|eg2|0.3.9 vscode-solution-explorer|fer|0.3.5 auto-close-tag|for|0.5.6 code-runner|for|0.9.14 auto-using|Fud|0.7.9 html-preview-vscode|geo|0.2.5 minify|Hoo|0.4.3 rest-client|hum|0.22.2 csharpextensions|jch|1.3.0 docomment|k--|0.1.8 git-indicators|lam|2.1.1 code-beautifier|mic|2.3.3 vscode-scss|mrm|0.6.2 azure-pipelines|ms-|1.157.4 vscode-apimanagement|ms-|0.1.1 vscode-azureappservice|ms-|0.16.0 vscode-azurefunctions|ms-|0.18.1 vscode-azurestorage|ms-|0.7.1 vscode-cosmosdb|ms-|0.11.0 vscode-docker|ms-|0.8.1 azure-account|ms-|0.8.6 azurecli|ms-|0.4.6 csharp|ms-|1.21.4 powershell|ms-|2019.9.0 vscode-node-azure-pack|ms-|0.0.9 vscode-typescript-tslint-plugin|ms-|1.2.2 azurerm-vscode-tools|msa|0.7.0 debugger-for-chrome|msj|4.12.0 color-highlight|nau|2.3.0 material-icon-theme|PKi|3.9.1 typescript-hero|rbb|3.0.0 vscode-manage-user-secrets|Rep|1.0.4 azure-iot-toolkit|vsc|2.10.0 vscode-icons|vsc|9.4.0 vscode-import-cost|wix|2.12.0 html-css-class-completion|Zig|1.19.0
IllusionMH commented 5 years ago

/confirmed

Came here to report same issue and looks like this is new issue (at least I don't remember it yesterday).

Problem occur if I use Tab to insert suggestion, but it works OK if I use Enter. At least this is behavior I see in JS files.

@StickNitro can you check if there is difference between using Tab and Enter in your case?

Version: 1.40.0-insider (user setup) Commit: 72bc289d32ec4f867e73b7f1f2a22f7d614ae2bb Date: 2019-10-11T05:44:05.506Z Electron: 6.0.12 Chrome: 76.0.3809.146 Node.js: 12.4.0 V8: 7.6.303.31-electron.0 OS: Windows_NT x64 10.0.18362

StickNitro commented 5 years ago

@IllusionMH In my case was happening whether I use Tab, Enter or select using the mouse. If I undo Cmd+Z and the try the IntelliSense again using ^+Space then it seems to work.

isidorn commented 5 years ago

Looks like a duplicate, I think there is already a PR which tackles this. Though leaving up to @jrieken to close

IllusionMH commented 5 years ago

My search skill let me down today. Yes, looks like duplicate of #82324, PR with fix #82349

vscodebot[bot] commented 5 years ago

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!