search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.54k stars 29.4k forks source link

[themes] Minimal icon theme should use icon font #86308

Open sbatten opened 4 years ago

sbatten commented 4 years ago

image

Look at multiroot icon, file icons in explorer, file icons in search panel. refs #85143

bpasero commented 4 years ago

@misolori is there any special CSS rule you set for icon font to work? since the text next to it has LCD rendering I wonder why the icon font does not.

miguelsolorio commented 4 years ago

The icons that are using grayscale aa are likely SVG and not an icon font. For the multi-root icon, once https://github.com/microsoft/vscode/issues/84695 is finalized we can update our built-in extensions to use the icon font. But icons from other extensions won't have this ability unless they're using our icons from the icon font. This is also the same issue as #85297.

bpasero commented 4 years ago

Thanks, I was not aware we are still using SVGs. I have updated the summary. The gist is that our minimal icon theme (which we ship by default) needs to use an icon font as well.

image

miguelsolorio commented 4 years ago

This is dependent on #90911, moving this to the backlog

miguelsolorio commented 3 years ago

@aeschli we'll need to add support for referencing codicons in file icon themes for this