search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.81k stars 29.12k forks source link

Search view checkboxes use greyscale aa #86310

Open sbatten opened 4 years ago

sbatten commented 4 years ago

image

not sure if this is equivalent to https://github.com/microsoft/vscode/issues/85589 since the text in the box is using proper SPAA

refs #85143

deepak1556 commented 4 years ago

@sbatten this one is different, the textarea in the other issue is affected by the system font. I have an idea about the upstream issue thats causing it. Will post updates there tomorrow.

bpasero commented 4 years ago

This came in from @misolori via https://github.com/microsoft/vscode/commit/c109f9a5d42c5158bf12e5a60dee21c369f2eddd. It looks like the background color is set to transparent which likely causes this.

image

miguelsolorio commented 4 years ago

I'll update this so it's only using a background when set.

miguelsolorio commented 4 years ago

After looking into this, the transparent border/background is not affecting the grayscale, I added a new icon (plain) on a separate DOM node, and it is also affected:

image

What's interesting is if I play with the positioning, there's a threshold where it will switch from aa to grayscale, so it appears that the input is causing the grayscale:

gif

And hiding the input removes the grayscale aa: image