Terminal's selection is wrong visually after resizing terminal

yrambler2001 commented 4 years ago

VSCode Version: 1.42.1
OS Version: macOS 10.14.4 (18E2034)

Steps to Reproduce:

select text to the end of line
reduce width of terminal

Tyriar commented 4 years ago

Can you share your settings.json?

yrambler2001 commented 4 years ago

@Tyriar

{
    "git.autofetch": true,
    "window.zoomLevel": 0,
    "breadcrumbs.enabled": true,
    "cSpell.userWords": [
        "Bcrypted",
        "Dropdown",
        "Editables",
        "Formik",
        "Saml",
        "Scrollable",
        "endregion",
        "flatpickr",
        "glyphicon",
        "hocs",
        "nullish",
        "refetch",
        "signin",
        "simpl",
        "toastify",
        "upsert"
    ],
    "javascript.updateImportsOnFileMove.enabled": "never",
    "editor.tabSize": 2,
    "prettier.useTabs": false,
    "prettier.tabWidth": 2,
    "[javascript]": {
        "editor.defaultFormatter": "vscode.typescript-language-features"
    },
    "workbench.sideBar.location": "left",
    "[json]": {
        "editor.defaultFormatter": "vscode.json-language-features"
    },
    "terminal.integrated.rendererType": "dom",
    "gitlens.hovers.currentLine.over": "line",
    "[jsonc]": {
        "editor.defaultFormatter": "esbenp.prettier-vscode"
    },
    "search.followSymlinks": false,
    "cSpell.enabledLanguageIds": [
        "asciidoc",
        "bat",
        "c",
        "cpp",
        "csharp",
        "css",
        "git-commit",
        "go",
        "graphql",
        "handlebars",
        "haskell",
        "html",
        "jade",
        "java",
        "javascript",
        "javascriptreact",
        "json",
        "jsonc",
        "latex",
        "less",
        "markdown",
        "php",
        "plaintext",
        "pug",
        "python",
        "restructuredtext",
        "rust",
        "scala",
        "scss",
        "text",
        "typescript",
        "typescriptreact",
        "yaml",
        "yml"
    ],
    "diffEditor.ignoreTrimWhitespace": false,
    "prettier.printWidth": 300
}

Disabling the extensions has no effect. Thanks.

yrambler2001 commented 4 years ago

Just found it happens only when

"terminal.integrated.rendererType": "dom"

The same happens on my second PC Windows 10 1.42.1 VSCode

Tyriar commented 4 years ago

@yrambler2001 perfect, can reproduce 👍

Tyriar commented 4 years ago

Upstream issue: https://github.com/xtermjs/xterm.js/issues/2818

tabaddor commented 4 years ago

I can reproduce this as well, what are thoughts on this issue thus far?

It seems as if this issue is solely due to the upstream issue in xtermjs linked above, although that issue still appears unresolved? May take a crack at that.

Tyriar commented 4 years ago

@tabaddor responded https://github.com/xtermjs/xterm.js/issues/2818#issuecomment-645327893

Tyriar commented 3 years ago

This is fixed because we hide the overflow. For better selection re-rendering there is also the upstream issue.

microsoft / vscode

Terminal's selection is wrong visually after resizing terminal #90903