Custom editor autosave menubar state not updated properly

[mjbvz]

Hi @mjbvz @jrieken,

I've been catching up with the daily updates, thanks for them btw. While working on our stuff, I've been noticing some issues on VSCode. Probably they're known issues but I'm sharing here in case they've been missed somehow. I'm able to reproduce them on both our code and this code.

Linux and Windows

• [File -> Auto Save] Auto save enabled: "Save" is not triggered if you quickly (less than 1s) close the editor after making a change.

Linux-only

• [File -> Auto Save] The "check" symbol is not shown when you enable "auto save" within the custom editor; however, the operation works.
• [File -> Revert File] Sometimes the menu button is kept disabled when you start VSCode, even after changes.
• [File -> Save All] Same behavior ^
• [File -> Save] Same behavior ^; Ctrl+S works.
• [File -> Save As] Same behavior ^; Ctrl+Shift+S works. note: the menu buttons become enabled when I open a text editor

Windows-only

• [File -> Revert File] Can't use; always disabled.

Please let me know if you need any further information.

Originally posted by @caponetto in https://github.com/microsoft/vscode/issues/77131#issuecomment-620571200

[mjbvz]

Wrong issue reference

[mjbvz]

@caponetto All of these should be fixed now except for the save menu items being disabled on first open. I'm having trouble tracking down why that is still happening

[mjbvz]

I've extracted the menus being disabled to #99407 so that we can verify the rest of these issues have been fixed

[JacksonKearl]

Is this regarding specifically text or binary custom editors? I'm seeing autosave afterdelay working correctly in both stable and insiders for text, but broken in both sable and insiders for binary.

Steps:

open .pawDraw with autoSave ondelay. make edits then quickly close. open again, edits are gone. if you wait a second before closing, the edits will persist.

[JacksonKearl]

[File -> Auto Save] The "check" symbol is not shown when you enable "auto save" within the custom editor; however, the operation works.

Still seeing this in insiders, the "Toggle Autosave" command occasionally doesn't seem to be reflected in the menu entry until a non-custom editor is rendered.

For instance here auto-save is off:

[fengzhiyang2019]

@

• [ ]

[mjbvz]

I just tested this again with the paw draw editor and it seems like the auto save entry is now reflected properly

If you're still seeing any issues related to this, please share the steps so I can investigate again

[lramos15]

Still seeing autosave state issues