Closed rebornix closed 4 years ago
Can't open Insiders anymore after the crash, I have to download again from the website and replace the binary.
Yeah unfortunately the build that went out last Friday was a bad one, I don't see a graceful way of recovering from it rather than manually downloading the latest release.
/cc @bpasero
In https://github.com/microsoft/vscode/tree/ben/verify-signed-bits I am working on a build step that tries to start VSCode after it has been signed. This should prevent this from happening in the future.
Should we pin this issue to warn users to re-download insiders on macOS ?
On Friday , the macOS insiders build that was released with commit id 161d93bb78 had incorrect signed bits which causes crash on startup.
Fix
Download latest insiders from https://code.visualstudio.com/insiders/ and replace the one in your /Applications
folder, this will not affect any of your existing configurations, settings etc. It will just replace the correct binary.
Moving Forward
This issue was unnoticed in our ci testing because the signing step happens as the last step before publishing which was done on purpose to reduce the turnaround on failed build jobs, https://github.com/microsoft/vscode/issues/97517#issuecomment-626796145 will address this nature of issues and signal right failures before publishing.
With https://github.com/microsoft/vscode/commit/9798bdde872af60016fec7b44f37ff29b93ab5c4 the build machine will try to run code-insiders -v
which should fail when something is wrong with entitlements.
I could not get this to run on Windows due to lack of Powershell skills on this for me very exotic script system where I do not feel comfortable.