search

microsoft / vsmarketplace

Customer feedback and issue tracker repository for Visual Studio Marketplace
MIT License
39 stars 10 forks source link

Wrong encoding in extension License link #628

Open jruales opened 1 year ago

jruales commented 1 year ago

Does this issue occur when all extensions are disabled?: N/A

Steps to Reproduce:

  1. Create a VS code extension where the License file has non-ASCII characters. Use UTF-8 encoding for the file.
  2. Publish the extension
  3. Open the License link from the marketplace page for the extension image
  4. Any non-ASCII characters now look messed up in the file that pops up image image

An example of an extension that has this issue is the Azure Machine Learning extension. But this is an issue in VS Code itself, not in any particular extension. Any extension that has non-ASCII has this issue.

Note: The encoding issue doesn't show up when following the License link from the Marketplace page, only when clicking the link in the VS Code marketplace https://marketplace.visualstudio.com/items/ms-toolsai.vscode-ai/license

sandy081 commented 1 year ago

I tried ms-toolsai.vscode-ai extension and the license link opens properly for me. Can you please provide the exact extension you are having the issue?

jruales commented 1 year ago

@sandy081 here's the direct link to the License for ms-toolsai.vscode-ai that appears when clicking on License from within VS Code itself: https://ms-toolsai.gallerycdn.vsassets.io/extensions/ms-toolsai/vscode-ai/0.28.0/1678213352093/Microsoft.VisualStudio.Services.Content.License

If you see under clause 2.b. it says "(collectively, “Build Devices”)" with those strange characters.

If you see the same license from the link that's linked from the web version of the marketplace (https://marketplace.visualstudio.com/items/ms-toolsai.vscode-ai/license) you'll notice that the encoding is correct and it says "(collectively, “Build Devices”)"

Another example is the Data Wrangler extension. Here's the direct link to the License page: https://ms-toolsai.gallerycdn.vsassets.io/extensions/ms-toolsai/datawrangler/0.2.1/1679242792198/Microsoft.VisualStudio.Services.Content.License There you can see the text with messed up encoding: "Remarque: Ce logiciel étant distribué au Canada, certaines des clauses dans ce contrat sont fournies ci-dessous en français." The text with correct encoding reads "Remarque: Ce logiciel étant distribué au Canada, certaines des clauses dans ce contrat sont fournies ci-dessous en français."