microsoft / vsmarketplace

Customer feedback and issue tracker repository for Visual Studio Marketplace
MIT License
39 stars 10 forks source link

Marketplace extension page hava a problem with displaying the markdown table when without `&ssr=false` param. #883

Open ygqygq2 opened 6 months ago

ygqygq2 commented 6 months ago

Without &ssr=false

https://marketplace.visualstudio.com/items?itemName=ygqygq2.turbo-file-header image

With &ssr=false

https://marketplace.visualstudio.com/items?itemName=ygqygq2.turbo-file-header&ssr=false#overview image

madhurivadaligithub commented 5 months ago

Hi @ygqygq2

Thank you for reaching VS Marketplace Team. We are looking into the issue and will get back to you with an update.

-VS Marketplace Team

agr commented 4 months ago

Apologies for the late response. There might be a bug in the marketplace SSR code that converts markdown to HTML. It seems to be triggered by empty code blocks in your table: image As a mitigation, I'd suggest to try to remove those from your table. Please, let me know if that helps.

ygqygq2 commented 4 months ago

@agr I disagree. I think they are not the same way of rendering.

https://marketplace.visualstudio.com/items?itemName=ygqygq2.turbo-file-header Just use the same method as that: https://marketplace.visualstudio.com/items?itemName=ygqygq2.turbo-file-header&ssr=false#overview

agr commented 4 months ago

There is a bug, fixing it will take some time. If you want your table to look nice in both cases now, I suggested a workaround. Feel free to wait until the bug is fixed though.

agr commented 4 months ago

I've been pointed out that double backticks do not denote an empty code span, but opening a code span where single backticks are ignored. So, what happens here is that double backtick in the first row opens a code span which lasts until another double backtick in the second row. Which in turn destroys any chance of parsing table as table and it seems to be the correct behavior here, although counterintuitive.