search

microsoft / vso-agent

Visual Studio Team Services and TFS agent for Mac OSX and Linux
MIT License
132 stars 57 forks source link

#253 - Update TestResultReader.ts to Handle jUnit Results with Empty Suites #255

Closed darthtrevino closed 8 years ago

darthtrevino commented 8 years ago

This gist of this fix is basically on this line: https://github.com/Microsoft/vso-agent/compare/master...darthtrevino:master#diff-c239605f4d523f5bd8f9cd70928887daR337

The code that was executed per child node was looking a little scary, cyclomatic-complexity wise, so I did a very minor function extraction.

Closes #253

msftclas commented 8 years ago

Hi @darthtrevino, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

msftclas commented 8 years ago

@darthtrevino, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

nigurr commented 8 years ago

@darthtrevino Can you please resolve the conflicts? Rest of the code is pretty good now. Thanks for adding test execution in default build process.

darthtrevino commented 8 years ago

Aye aye. Upstream is merged.