Resolve the archive creation properly

microsoft / vso-agent

Visual Studio Team Services and TFS agent for Mac OSX and Linux

MIT License

132 stars 57 forks source link

Resolve the archive creation properly #259

Closed nigurr closed 8 years ago

nigurr commented 8 years ago

Manual Testing done and verified.

Issue: Archiving the files resolves the response before archive file is getting created which can cause corrputed archives.

Fix: Use file stream close call to resolve the response, which guarantees that file is closed and archive is completed

msftclas commented 8 years ago

Hi @nigurr, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Nitin Gurram). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

acesiddhu commented 8 years ago

looks fine