search

microsoft / vstest

Visual Studio Test Platform is the runner and engine that powers test explorer and vstest.console.
MIT License
870 stars 316 forks source link

Use built in sha1 for id generation #5081

Closed nohwnd closed 3 weeks ago

nohwnd commented 3 weeks ago

Description

Use built-in sha1 and slice for id generation.

image image

Fix https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2050310 Fix https://github.com/microsoft/testfx/issues/2762

nohwnd commented 3 weeks ago

/azp run

azure-pipelines[bot] commented 3 weeks ago
Azure Pipelines successfully started running 1 pipeline(s).
nohwnd commented 3 weeks ago

@evangelink You are a code owner here, but I am just changing the underlying implementation and no tests were changed, and I also checked that the produced trx from old and new mstest SDK produces the same guids, so all should be good.

Evangelink commented 2 weeks ago

@Evangelink You are a code owner here, but I am just changing the underlying implementation and no tests were changed, and I also checked that the produced trx from old and new mstest SDK produces the same guids, so all should be good.

I didn't know I was :D

Thanks for the PR! Looking forward for the perf improvement.