Closed omajid closed 2 weeks ago
In XmlRunSettingsUtilities, we allocate various XmlReaders but don't always Diposes them
XmlRunSettingsUtilities
XmlReader
Dipose
https://github.com/microsoft/vstest/blob/9ab8d6c00a359bc51887b0d29b85dbbfc4f91b28/src/Microsoft.TestPlatform.ObjectModel/Utilities/XmlRunSettingsUtilities.cs#L236
This is never Dispose()d.
Dispose()
All IDisposables are disposed.
IDisposable
Some IDisposables are not disposed in XmlRunSettingsUtilities.
N/A
Commit 9ab8d6c00a359bc51887b0d29b85dbbfc4f91b28
Description
In
XmlRunSettingsUtilities, we allocate variousXmlReaders but don't alwaysDiposes themSteps to reproduce
https://github.com/microsoft/vstest/blob/9ab8d6c00a359bc51887b0d29b85dbbfc4f91b28/src/Microsoft.TestPlatform.ObjectModel/Utilities/XmlRunSettingsUtilities.cs#L236
This is never
Dispose()d.Expected behavior
All
IDisposables are disposed.Actual behavior
Some
IDisposables are not disposed inXmlRunSettingsUtilities.Diagnostic logs
N/A
Environment
Commit 9ab8d6c00a359bc51887b0d29b85dbbfc4f91b28