Dispose XmlReader in XmlRunSettingsUtilities - Githubissues

microsoft / vstest

Visual Studio Test Platform is the runner and engine that powers test explorer and vstest.console.

MIT License

870 stars 316 forks source link

Dispose XmlReader in XmlRunSettingsUtilities #5094

Closed omajid closed 2 weeks ago

omajid commented 2 weeks ago

Description

The existing code disposes the underlying stream, but not the XmlReader itself, even though the XmlReader is an IDisposable too.

Related issue

Fixes: https://github.com/microsoft/vstest/issues/5093

[ ] I have ensured that there is a previously discussed and approved issue.