microsoft / vsts-authentication-library-for-java

Retrieve OAuth2 or Personal Accesss Tokens for Visual Studio Team Services (visualstudio.com) accounts. Also provides secure storage for those secrets on different platforms.
MIT License
18 stars 20 forks source link

OAuth2Authenticator.getOAuth2TokenPair() is unable to use refresh token #15

Closed maartenba closed 6 years ago

maartenba commented 6 years ago

OAuth2Authenticator.getOAuth2TokenPair() is unable to use refresh token. Here is what happens and what we see:

Net result: NullPointerException is never caught and bubbles up to the caller, making refresh tokens impossible to use.

I have created a pull request that fixes this NullPointerException. If possible, can a new build of the library be created?

/cc @DavidStaheli

maartenba commented 6 years ago

@DavidStaheli Any news on the Maven artifacts? :-)