search

microsoft / vsts-authentication-library-for-java

Retrieve OAuth2 or Personal Accesss Tokens for Visual Studio Team Services (visualstudio.com) accounts. Also provides secure storage for those secrets on different platforms.
MIT License
18 stars 20 forks source link

Expose flow control logic in the response object #2

Closed yacaovsnc closed 8 years ago

yacaovsnc commented 8 years ago

The DeviceFlowResponse object is passed back to the callback and is used as a message channel between the consumer and this library. This remove threading requirement from the library and the consumer will be repsonsible for proper threading.

The logic is added to DeviceFlowResponse class to maintain backward compatibility.

msftclas commented 8 years ago

Hi @yacaovsnc, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Yang Cao (VSNC)). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

davidstaheli commented 8 years ago

Looks good to me.