Adding the ability to configure an agent to join an Elastic Pool in BYOS

wireznak commented 4 years ago

The full spec sheet / design doc for this feature can be found on the AzureDevOps.Docs repository, under the branch users/wireznak/vsts-azure-extension-proposal, file path /Pipelines/BYOS/vsts-azureextension-modification-spec.md.

We wish to avoid using the Custom Script Extension to install the build agent software on virtual machines submitted to us through BYOS, because the customer may want to use this extension for their own purposes and Virtual Machine Scale Sets may only have one copy of each unique type of Azure Extension. Instead, we will re-use the existing Azure Pipelines Agent extension, using a special setting to configure the build agent to connect to the Elastic Pool. This entails the following:

A flag value IsPipelinesAgent that activates the new code branch.
A string value PoolName that gives the name of the pool to which the agent should connect.
New code branches in the validation steps to selectively validate the settings based on which settings are relevant to the current mode.
Logging to track when we're in "Pipelines mode".
Different command-line arguments will be used to configure the agent software depending on whether "pipelines mode" is enabled.
New unit tests to confirm the above behaviors.

bishal-pdMSFT commented 4 years ago

@tejasd1990 please review this

tejasd1990 commented 4 years ago

@wireznak I have partially reviewed and left some comments. Will review the remaining PR later today

tejasd1990 commented 4 years ago

@wireznak left some comments. The same comments apply for windows extension as well. I am yet to review the tests, I will do that.

microsoft / vsts-azurevm-extension

Adding the ability to configure an agent to join an Elastic Pool in BYOS #178