microsoft / vsts-cloudfoundry

Azure DevOps Extension for Cloud Foundry
MIT License
20 stars 23 forks source link

Push step is not respecting the domain setting #22

Closed mozts2005 closed 5 years ago

mozts2005 commented 5 years ago
// Extension\CloudFoundry\cloudfoundry.ts
 if (tl.getBoolInput('useRoute')) {
                let domainOption: string = tl.getInput('domainOptions');
                if (domainOption === 'custom') {
                    if (tl.getInput('domain')) {
                        cfPush.arg('-d');
                        cfPush.arg(tl.getInput('domain'));
                    }
                }

                if (tl.getInput('host')) {
                    cfPush.arg('--hostname');
                    cfPush.arg(tl.getInput('host'));
                }
            } else {
                cfPush.arg('--no-route');
            }

There is no option for "domainOptions" so it is defaulted to empty srtring. check should be removed

mozts2005 commented 5 years ago

fixed in PR #19

madhurig commented 5 years ago

Thanks for your contribution. A new version (1.147.0) of the extension with this fix has been published. The changes will be automatically deployed to your Azure DevOps organization. Let us know if you see any issues.