search

microsoft / vsts-cordova-tasks

Streamline CI setup for your Apache Cordova, PhoneGap, Ionic, or Cordova CLI compatible app using a set of useful pre-defined build steps for VS Team Services or TFS
http://go.microsoft.com/fwlink/?LinkID=691188
Other
25 stars 27 forks source link

add check and fallback for configuration value #7

Closed ryuyu closed 8 years ago

ryuyu commented 8 years ago

Adding a check for strange/empty values for configuration and defaulting to release when this happens.

@dlevine82 @Chuxel

Chuxel commented 8 years ago

Looks like a reasonable fix. Can you add a note to the info message in task.json indicating release is the default?

MSLaguana commented 8 years ago

Isn't the typical Cordova default to use debug unless specified otherwise?

Chuxel commented 8 years ago

For the command line, sure. CI one could make an argument either way. Generally you'll be dong some form of release build (ex: ad-hoc for iOS) in that environment. Given iOS restrictions in particular a debug build tied to "iPhone Developer" has limited value. Xamarin iOS defaults to Release.

However, I did a check and the default CI template for VS currently sets debug. I'm okay with switching to debug as the default for consistency with the Cordova CLI given that fact. If they were both release I'd say we stick with release.