search

microsoft / vsts-extension-multivalue-control

A work item form control which allows selection of multiple values.
MIT License
46 stars 45 forks source link

vsts-extensions-multivalue-control - not showing as Required Field #106

Closed vbpAlex closed 5 years ago

vbpAlex commented 5 years ago

Trying to customize TFS wotk item by adding vsts-extensions-multivalue-control.

Control loaded successfully, but how to make it REQUIRED, because i don't see it. 

Control contribution:
    Id: ms-devlabs.vsts-extensions-multivalue-control.multivalue-form-control
    Description: A work item form control which allows selection of multiple values.
    Inputs:
        Id: FieldName
        Description: 
        Type: WorkItemField
        Field Type: String; PlainText; HTML
        Data Type: String
        IsRequired: true

        Id: Values
        Description: Values can be user provided or from suggested values of the backing field
        Data Type: String
        IsRequired: true

        Id: AllowCustom
        Description: 
        Data Type: Boolean
        IsRequired: false

Thanks in advance.

mmanela commented 5 years ago

Make the field that it is targeting required should do it

vbpAlex commented 5 years ago

Matthew, but i did specified REQUIRED in field definition, still no luck:

<FIELD name="Multi Value" refname="Microsoft.VSTS.Common.MultiValue" type="String" reportable="dimension">

         <REQUIRED />

            <SUGGESTEDVALUES expanditems="true">

            <LISTITEM value="A" />

            <LISTITEM value="B" />

            <LISTITEM value="B" />

          </SUGGESTEDVALUES>

           <HELPTEXT>Impacted Area's</HELPTEXT>

  </FIELD>

ReplyForward https://drive.google.com/u/0/settings/storage?hl=en https://www.google.com/intl/en/policies/terms/ https://www.google.com/intl/en/policies/privacy/ https://www.google.com/gmail/about/policy/

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free. www.avg.com http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Thu, May 9, 2019 at 4:46 PM Matthew Manela notifications@github.com wrote:

Make the field that it is targeting required should do it

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/microsoft/vsts-extension-multivalue-control/issues/106#issuecomment-491059744, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGU2QSDPWKIILEUOH7DM53PUSERBANCNFSM4HL25JLQ .

mmanela commented 5 years ago

That should be right, is it letting you save the form without setting it?

vbpAlex commented 5 years ago

I didn't try, but was expecting to see red icon as for the rest of my fields where attribute REQUIRED is available.

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free. www.avg.com http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Thu, May 9, 2019 at 5:28 PM Matthew Manela notifications@github.com wrote:

That should be right, is it letting you save the form without setting it?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/microsoft/vsts-extension-multivalue-control/issues/106#issuecomment-491075425, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGU2QQ6GGSEKQU3KQ3CO23PUSJOJANCNFSM4HL25JLQ .

mmanela commented 5 years ago

There was a bug on that in the past. What version are you on?

Either way, it should be required even if it doesn't show

vbpAlex commented 5 years ago

Anyway to specify that this is required field before Saving?

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free. www.avg.com http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Thu, May 9, 2019 at 5:33 PM Matthew Manela notifications@github.com wrote:

There was a bug on that in the past. What version are you on?

Either way, it should be required even if it doesn't show

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/microsoft/vsts-extension-multivalue-control/issues/106#issuecomment-491076859, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGU2QRTAPXBTQDQAGLXDE3PUSKCJANCNFSM4HL25JLQ .

mmanela commented 5 years ago

It should be required already. It may be just a bug that it isn't showing the required icon

vbpAlex commented 5 years ago

let me test and I'll let you know.outcome.

Greatly appreciated your quick responses.

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free. www.avg.com http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Thu, May 9, 2019 at 5:38 PM Matthew Manela notifications@github.com wrote:

It should be required already. It may be just a bug that it isn't showing the required icon

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/microsoft/vsts-extension-multivalue-control/issues/106#issuecomment-491078358, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGU2QVYFP6BGWREN7OZDI3PUSKWXANCNFSM4HL25JLQ .

vbpAlex commented 5 years ago

Matthew, i have checked the version and it is TFS 2017, but REQUIRED is not working and also I have noticed that "Save and Close" disabled as well.

Please see attached, maybe you have any clues?

Thanks Alex.

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free. www.avg.com http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Thu, May 9, 2019 at 5:43 PM LINA P portnayam@gmail.com wrote:

let me test and I'll let you know.outcome.

Greatly appreciated your quick responses.

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free. www.avg.com http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#m_4003630064408976931_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Thu, May 9, 2019 at 5:38 PM Matthew Manela notifications@github.com wrote:

It should be required already. It may be just a bug that it isn't showing the required icon

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/microsoft/vsts-extension-multivalue-control/issues/106#issuecomment-491078358, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGU2QVYFP6BGWREN7OZDI3PUSKWXANCNFSM4HL25JLQ .

mmanela commented 5 years ago

Can you describe on what way is it not working?

-Matt

From: vbpAlex notifications@github.com Sent: Friday, May 10, 2019 6:56:48 AM To: microsoft/vsts-extension-multivalue-control Cc: Matthew Manela; Comment Subject: Re: [microsoft/vsts-extension-multivalue-control] vsts-extensions-multivalue-control - not showing as Required Field (#106)

Matthew, i have checked the version and it is TFS 2017, but REQUIRED is not working and also I have noticed that "Save and Close" disabled as well.

Please see attached, maybe you have any clues?

Thanks Alex.

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free. www.avg.com http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Thu, May 9, 2019 at 5:43 PM LINA P portnayam@gmail.com wrote:

let me test and I'll let you know.outcome.

Greatly appreciated your quick responses.

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free. www.avg.com http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#m_4003630064408976931_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Thu, May 9, 2019 at 5:38 PM Matthew Manela notifications@github.com wrote:

It should be required already. It may be just a bug that it isn't showing the required icon

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/microsoft/vsts-extension-multivalue-control/issues/106#issuecomment-491078358, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGU2QVYFP6BGWREN7OZDI3PUSKWXANCNFSM4HL25JLQ .

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vsts-extension-multivalue-control/issues/106#issuecomment-491297971, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AACKKGUIEQXKJGUQJR3XKFLPUV5KBANCNFSM4HL25JLQ.

vbpAlex commented 5 years ago

First of all I would like to apologize because i'm a new here.

Issue or discrepancy based on my expectations are:

  1. Missing icon that identified field as Required.
  2. When i create a new Work Item, "Save & Close" disabled, how to Save changes.

Thanks Alex.

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free. www.avg.com http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Fri, May 10, 2019 at 10:01 AM Matthew Manela notifications@github.com wrote:

Can you describe on what way is it not working?

-Matt

From: vbpAlex notifications@github.com Sent: Friday, May 10, 2019 6:56:48 AM To: microsoft/vsts-extension-multivalue-control Cc: Matthew Manela; Comment Subject: Re: [microsoft/vsts-extension-multivalue-control] vsts-extensions-multivalue-control - not showing as Required Field (#106)

Matthew, i have checked the version and it is TFS 2017, but REQUIRED is not working and also I have noticed that "Save and Close" disabled as well.

Please see attached, maybe you have any clues?

Thanks Alex.

< http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail

Virus-free. www.avg.com < http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail

<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Thu, May 9, 2019 at 5:43 PM LINA P portnayam@gmail.com wrote:

let me test and I'll let you know.outcome.

Greatly appreciated your quick responses.

< http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> Virus-free. www.avg.com < http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail

<#m_4003630064408976931_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Thu, May 9, 2019 at 5:38 PM Matthew Manela notifications@github.com wrote:

It should be required already. It may be just a bug that it isn't showing the required icon

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/microsoft/vsts-extension-multivalue-control/issues/106#issuecomment-491078358 , or mute the thread < https://github.com/notifications/unsubscribe-auth/ABGU2QVYFP6BGWREN7OZDI3PUSKWXANCNFSM4HL25JLQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub< https://github.com/microsoft/vsts-extension-multivalue-control/issues/106#issuecomment-491297971>, or mute the thread< https://github.com/notifications/unsubscribe-auth/AACKKGUIEQXKJGUQJR3XKFLPUV5KBANCNFSM4HL25JLQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/microsoft/vsts-extension-multivalue-control/issues/106#issuecomment-491299543, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGU2QWMNTLNUVPSXTBZHU3PUV52ZANCNFSM4HL25JLQ .

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free. www.avg.com http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

mmanela commented 5 years ago

The icon missing is a known bug in that version. But for #2, save and close should be disabled if a field is required.

-Matt

From: vbpAlex Sent: Friday, May 10, 2019 7:19 AM To: microsoft/vsts-extension-multivalue-control Cc: Matthew Manela; Comment Subject: Re: [microsoft/vsts-extension-multivalue-control]vsts-extensions-multivalue-control - not showing as Required Field (#106)

First of all I would like to apologize because i'm a new here.

Issue or discrepancy based on my expectations are:

  1. Missing icon that identified field as Required.
  2. When i create a new Work Item, "Save & Close" disabled, how to Save changes.

Thanks Alex.

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free. www.avg.com http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Fri, May 10, 2019 at 10:01 AM Matthew Manela notifications@github.com wrote:

Can you describe on what way is it not working?

-Matt

From: vbpAlex notifications@github.com Sent: Friday, May 10, 2019 6:56:48 AM To: microsoft/vsts-extension-multivalue-control Cc: Matthew Manela; Comment Subject: Re: [microsoft/vsts-extension-multivalue-control] vsts-extensions-multivalue-control - not showing as Required Field (#106)

Matthew, i have checked the version and it is TFS 2017, but REQUIRED is not working and also I have noticed that "Save and Close" disabled as well.

Please see attached, maybe you have any clues?

Thanks Alex.

< http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail

Virus-free. www.avg.com < http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail

<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Thu, May 9, 2019 at 5:43 PM LINA P portnayam@gmail.com wrote:

let me test and I'll let you know.outcome.

Greatly appreciated your quick responses.

< http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> Virus-free. www.avg.com < http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail

<#m_4003630064408976931_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Thu, May 9, 2019 at 5:38 PM Matthew Manela notifications@github.com wrote:

It should be required already. It may be just a bug that it isn't showing the required icon

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/microsoft/vsts-extension-multivalue-control/issues/106#issuecomment-491078358 , or mute the thread < https://github.com/notifications/unsubscribe-auth/ABGU2QVYFP6BGWREN7OZDI3PUSKWXANCNFSM4HL25JLQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub< https://github.com/microsoft/vsts-extension-multivalue-control/issues/106#issuecomment-491297971>, or mute the thread< https://github.com/notifications/unsubscribe-auth/AACKKGUIEQXKJGUQJR3XKFLPUV5KBANCNFSM4HL25JLQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/microsoft/vsts-extension-multivalue-control/issues/106#issuecomment-491299543, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGU2QWMNTLNUVPSXTBZHU3PUV52ZANCNFSM4HL25JLQ .

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free. www.avg.com http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

vbpAlex commented 5 years ago

Matthew, greatly appreciated your help.

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free. www.avg.com http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Fri, May 10, 2019 at 10:20 AM Matthew Manela notifications@github.com wrote:

The icon missing is a known bug in that version. But for #2, save and close should be disabled if a field is required.

-Matt

From: vbpAlex Sent: Friday, May 10, 2019 7:19 AM To: microsoft/vsts-extension-multivalue-control Cc: Matthew Manela; Comment Subject: Re: [microsoft/vsts-extension-multivalue-control]vsts-extensions-multivalue-control

  • not showing as Required Field (#106)

First of all I would like to apologize because i'm a new here.

Issue or discrepancy based on my expectations are:

  1. Missing icon that identified field as Required.
  2. When i create a new Work Item, "Save & Close" disabled, how to Save changes.

Thanks Alex.

< http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail

Virus-free. www.avg.com < http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail

<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Fri, May 10, 2019 at 10:01 AM Matthew Manela notifications@github.com wrote:

Can you describe on what way is it not working?

-Matt

From: vbpAlex notifications@github.com Sent: Friday, May 10, 2019 6:56:48 AM To: microsoft/vsts-extension-multivalue-control Cc: Matthew Manela; Comment Subject: Re: [microsoft/vsts-extension-multivalue-control] vsts-extensions-multivalue-control - not showing as Required Field (#106)

Matthew, i have checked the version and it is TFS 2017, but REQUIRED is not working and also I have noticed that "Save and Close" disabled as well.

Please see attached, maybe you have any clues?

Thanks Alex.

<

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail

Virus-free. www.avg.com <

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail

<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Thu, May 9, 2019 at 5:43 PM LINA P portnayam@gmail.com wrote:

let me test and I'll let you know.outcome.

Greatly appreciated your quick responses.

<

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail

Virus-free.

www.avg.com <

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail

<#m_4003630064408976931_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Thu, May 9, 2019 at 5:38 PM Matthew Manela < notifications@github.com> wrote:

It should be required already. It may be just a bug that it isn't showing the required icon

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <

https://github.com/microsoft/vsts-extension-multivalue-control/issues/106#issuecomment-491078358

,

or mute the thread <

https://github.com/notifications/unsubscribe-auth/ABGU2QVYFP6BGWREN7OZDI3PUSKWXANCNFSM4HL25JLQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub<

https://github.com/microsoft/vsts-extension-multivalue-control/issues/106#issuecomment-491297971 , or mute the thread<

https://github.com/notifications/unsubscribe-auth/AACKKGUIEQXKJGUQJR3XKFLPUV5KBANCNFSM4HL25JLQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/microsoft/vsts-extension-multivalue-control/issues/106#issuecomment-491299543 , or mute the thread < https://github.com/notifications/unsubscribe-auth/ABGU2QWMNTLNUVPSXTBZHU3PUV52ZANCNFSM4HL25JLQ

.

< http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail

Virus-free. www.avg.com < http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail

<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/microsoft/vsts-extension-multivalue-control/issues/106#issuecomment-491306187, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGU2QXAZGEKGURXXCVBTETPUWACXANCNFSM4HL25JLQ .

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free. www.avg.com http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

vbpAlex commented 5 years ago

Hi There, please let me know if it possible somehow to highlight multivalue control? Thanks

mmanela commented 5 years ago

What do you mean?