search

microsoft / vsts-extension-multivalue-control

A work item form control which allows selection of multiple values.
MIT License
46 stars 45 forks source link

Separate Multivalue-Controls are identified as the same field: explicit definition of ALLOWEDVALUES broken #121

Closed xymunter closed 2 years ago

xymunter commented 4 years ago

I assume the issue I will describe in the following is somehow related to an issue I encountered some time ago:

@xymunter as we talked over skype, this is a UI bug in TFS 2018 and has been fixed in TFS 2019. The bug is that we will accidently identify them as the same field if they are using the same contribution.

Originally posted by @joezha in https://github.com/microsoft/vsts-extension-multivalue-control/issues/99#issuecomment-472971262

I fear this behavior is now a regression issue in TFS 2019 (Azure DevOps - ADOS).

We're still using Multivalue control 2.2.25. Furthermore, we've installed the latest security update.

So our version shows as the following: image

The Dev suffix seems somewhat curious....

After the update we encountered some issues, among other things, the Multivalue-Controls we use to display GlobalList entries are broken now. Somehow they now show the contents of all GlobalLists bound to a specific (custom) field.

Even if I explicitly define a set of ALLOWEDVALUES for the multivalue control still the data of the GlobalLists is used. If I use a default Control of type FieldControl either with explicit set ALLOWEDVALUES or bound to a GlobalList, the correct number of values is shown.

Unfortunately, the GlobalLists I'm speaking of contain customer related data, which is confidential. I'd wait if you can reproduce this behavior, and will create some test data if needed.

jozhan commented 4 years ago

I can repro the issue. Looking into it.

sunahe commented 4 years ago

Same issue on our server installation. Looks like the behaviour of "/_api/_wit/allowedvalues" changed in one of the recent Azure DevOps server updates.

I opened a uservoice issue for Azure DevOps. According to them, that api is unsupported and another API should be used instead: https://developercommunity.visualstudio.com/comments/815848/view.html

jozhan commented 4 years ago

@sunahe sorry for inconvenience, we have identified the root cause and the fix will be included in the future Update 1.1 RTM.

xymunter commented 4 years ago

I was informed that we have installed the Update 1.1 RTM on a test instance of Azure DevOps Server 2019:

image

As of yet, the problem still exists....

xymunter commented 4 years ago

Can you give me feedback, if the version I posted some time ago is the Update 1.1 RTM? If so, this issue really isn't fixed.

xymunter commented 3 years ago

@jozhan Can you give me some feedback, please? The issue is still present in Version Dev17.M153.5.

StephenRSkinner commented 3 years ago

When is this going to be fixed. This is the second open issue I've found for the same issue. #130 opened almost a year ago is the same issue, with no resolution. This control is basically useless if it doesn't properly display values as configured.

xymunter commented 3 years ago

So we're currently testing Azure DevOps Server 2020 (on premise), and from the first looks I got it seems this problem finally is fixed.... @StephenRSkinner maybe this is also interesting for you.

All in all I'm quite sad that this topic didn't even get a response anymore since Nov 2019....I have had different experiences in the past, but it seems, that is not the norm.

xymunter commented 2 years ago

We now rolled out the update to Azure DevOps Server 2020 (on prem), and the bug is fixed.

Again, I'm quite upset not getting any further reactions at all.

MOlausson commented 2 years ago

@xymunter Great to see it worked out. Sorry for the silence but we're ramping up the work on the MS DevLabs extensions again, working through the latest issues first.