Fix #128 Custom Value Casing

microsoft / vsts-extension-multivalue-control

A work item form control which allows selection of multiple values.

MIT License

47 stars 45 forks source link

Fix #128 Custom Value Casing #193

Closed PelvicSorcerer closed 2 years ago

PelvicSorcerer commented 2 years ago

Custom values entered by the user are lower-cased for matching purposes in the filter. When this value is returned to be displayed and saved however, it should be in its original state--not lower-cased.

Issue #128

ghost commented 2 years ago

All CLA requirements met.

PelvicSorcerer commented 2 years ago

@MOlausson, tagging you since you were the last to merge a PR here. This is hopefully a simple fix to a pretty unfortunate UX issue as described in Issue #128.

I tested these changes on a private Azure DevOps Services organization, as that's all I have access to. I'm new to open-source contribution, so please let me know if I need to change anything.

liamgjohannes commented 2 years ago

@madkoo, @NenoLoje please review and merge this fix. It's a major improvement for a minor fix.

NenoLoje commented 2 years ago

@madkoo, @NenoLoje please review and merge this fix. It's a major improvement for a minor fix.

Sorry, I don't have any write-access to this repo.

madkoo commented 2 years ago

If the owner of this PR can resolve the conflicts then we can accept and merge this fix

PelvicSorcerer commented 2 years ago

@madkoo, I have resolved the conflicts.

PelvicSorcerer commented 2 years ago

@madkoo, do you guys release on a schedule or is there any other way I can get a sense of when a release including this fix might get pushed to the Visual Studio Marketplace for Azure DevOps Extensions? I'm new to open-source and GitHub contribution, so if there's somewhere obvious I should have looked to find that info, let me know or even just post the link. We've been wanting to use this extension at our company, but this bug was a deal-breaker.

Thanks for the help!

madkoo commented 2 years ago

@PelvicSorcerer a new version is released as soon as the pull requests have been tested. Right now I tested your change and Im trying to understand the fix in your case - I entered a custom value but it still gets returned as lower-case.