search

microsoft / vsts-extension-multivalue-control

A work item form control which allows selection of multiple values.
MIT License
46 stars 44 forks source link

Fix data selection and truncation bugs, better support long label lengths #218

Closed Joshua-Barclay closed 1 year ago

Joshua-Barclay commented 1 year ago

I've combined these changes into one PR in the hope it will be easier for you to review and merge. Let me know if you need me to separate the changes out to separate PRs.

I've addressed a few of the most significant quality of life changes we need as a large enterprise user of this field. Specifically:

  1. 217

    Added trim() where the data is matched for selection in the UI when determining which checkboxes are checked. Will fix matching issues without affecting the underlying data.

  2. 208

    Added a configuration field to specify the maximum label length for each field. Defaults to 35 (current behaviour) if not set. Added a 'title' to each option with the full length label to show on mouse-over. Whilst this is not an optimal solution from an accessibility perspective I think it significantly improves the UX of long values for many users.

  3. 207

    Updated the wrapText function to ensure the append length and trunc length are the same (previously 15 and 35 respectively).

Joshua-Barclay commented 1 year ago

@microsoft-github-policy-service agree

Joshua-Barclay commented 1 year ago

@AminTi @madkoo

Hi team just want to make sure this was on your radar. This PR would be a huge usability improvement for us in a large enterprise environment.

madkoo commented 1 year ago

@Joshua-Barclay Thank you for reporting this , We will review the PR

madkoo commented 1 year ago

@MOlausson , Do you want to review as well? I think these are good changes

madkoo commented 1 year ago

Will merge your changes