microsoft / vsts-extension-multivalue-control

A work item form control which allows selection of multiple values.
MIT License
47 stars 45 forks source link

"Required" field indicator is displayed for multiple (all?) multi-value controls although it should be visible only for one #99

Closed xymunter closed 5 years ago

xymunter commented 5 years ago

TFS 2018.2 Multivalue control 2.2.25

I have a workitem type that contains two Multivalue controls. One of the bound fields is configured to be set as Required when the workitem is in the Closed state (so this is defined in the State tags, not in a Transition).

Here's what the configuration somewhat looks like:

configuraiton

This works well, actually a little bit too well: it seems as if all Multivalue controls are now being Required:

required

Now if the actually required Multivalue control gets selected, both indicator disappear:

fixed

mmanela commented 5 years ago

@xymunter Can you share your full xml file to I can test locally?

xymunter commented 5 years ago

Sure thing. See the WIT attached in this post. UserStory.zip

jozhan commented 5 years ago

@xymunter I wasn't able to reproduce it locally and I tried the same set up as the xml you provided. Is it okay that we look at your repro via online screen sharing? Please feel free to reach out to me @ joezha@microsoft.com if you need further help.

jozhan commented 5 years ago

@xymunter as we talked over skype, this is a UI bug in TFS 2018 and has been fixed in TFS 2019. The bug is that we will accidently identify them as the same field if they are using the same contribution.

xymunter commented 5 years ago

@joezha Thank you very much for your help. Really appreciate it.