search

microsoft / vsts-extension-retrospectives

An Azure DevOps extension for efficient retrospectives
MIT License
183 stars 82 forks source link

"Copy retrospective link" does not escape spaces #122

Closed Adam-Brinded closed 2 years ago

Adam-Brinded commented 3 years ago

An Azure DevOps project i use has a space in the project name. When copying the link to a restrospective the output does not escape the space, resulting in a broken link.

Example: Project name: Test Project output from "Copy retrospective link": https://dev.azure.com//Test Project/_apps/hub/ms-devlabs.team-retrospectives.home?teamId=boardId= Desired output: https://dev.azure.com//Test%20Project/_apps/hub/ms-devlabs.team-retrospectives.home?teamId=boardId=

ErikHansen1 commented 3 years ago

I'd like to reiterate that when you choose "Copy Retrospective" option on the A.D.O. Retrospective board it yields a link that is broken due to a space that's coded in there. Copy retro link button Broken retro link

robagale commented 3 years ago

Also want to highlight this. I need to use the link to paste into my team chat to get everyone into the Retrospective in a timely manner.

Adam-Brinded commented 2 years ago

This appears to be resolved by PR #271

ErikHansen1 commented 2 years ago

Thank you for getting this PR in. I just tested is out, @Adam-Brinded , and the fix works like a charm.

robagale commented 2 years ago

Noticed the fix the other day. Much appreciated.