extension doesn't honor users' theme selection

[polatengin]

Extension should honor users' theme selection.

It should be dark if user chose dark theme, light, if user chose light theme, etc.

My understanding is, in the main.scss file we need to have reference to _platformCommon.scss file

References

• Extension development
• Styles
• Sample Web Extension for Azure DevOps

[mpth]

As this extension uses the old vss web extension SDK the links you shared will not necessarily help us.

There is an undocumented option in the old extension SDK that could potentially work. I haven't used it myself but it should inject the current themes CSS variables into the extension iframe.

https://docs.microsoft.com/en-us/azure/devops/extend/reference/client/api/vss/references/vss_sdk_interfaces/iextensioninitializationoptions (see comments)

Only found this blog post in German that explains how it works :-) https://www.aitgmbh.de/blog/tfs-devops/theme-unterstuetzung-fuer-azure-devops-erweiterungen/

Switching to the new SDK is only an option if we can drop support for Azure DevOps Server versions that dont support the new SDK. I dont know what version that is but I'm sure we can find out.

[polatengin]

I think we can drop old Azure DevOps Server versions in favor to have newest and greatest features.

I didn't do that before, is it as simple as bumping dependency version in package.json or should we change codes in files as-well? Did you do that before?

[mpth]

This would mean we would lock out folks from updates that are currently using it with TFS Server 2018 Update 2/3. I'm all for it - just making sure this is clear.

The Estimate extension by @cschleiden targets both Azure DevOps Services and Azure DevOps server and uses the new SDK with theming support. Maybe he has some advice :)

[mpth]

Maybe we can try using the applyTheme initialization option first before thinking about switching out the SDK.

https://github.com/microsoft/vss-web-extension-sdk/pull/105

[polatengin]

it may solve this issue very quickly and easily 😊

I can test it out this weekend

[yayitserica]

@jankakoen will make color suggestions to @polatengin by 7/27 Monday.

[mindlessroman]

I believe most of the theme issues have been addressed. Worth closing @polatengin ?

[polatengin]

I'm closing this issue since "I think" all the theming issues addressed 👍