search

microsoft / vsts-extension-retrospectives

An Azure DevOps extension for efficient retrospectives
MIT License
183 stars 82 forks source link

Users can downvote issues that they didn't vote on. #273

Open HarmanDhunna opened 3 years ago

HarmanDhunna commented 3 years ago

Users can downvote issues that they didn't vote on, this gains them another vote and are able to vote on another item.

BCOps commented 3 years ago

Confirmed behaviour as per @HarmanDhunna feedback item. Same experience with my team.

D-Mellenthin commented 3 years ago

Should be easily with a short peek at the code this should be easily fixable with this addition in

https://github.com/microsoft/vsts-extension-retrospectives/blob/17dc0e0afcbe0b5791311f11bac5abebb857fa72/RetrospectiveExtension.Frontend/components/feedbackItem.tsx#L713

disabled={!isMainItem || !showVoteButton || this.state.userVotes < 1}

There a function private isVoted = async (feedbackItemId: string) {...}

that can probably be used for it, but i don't know react and if you could use async method in the disabled binding. And it returns a string, so we would need a comparison anyways.

I haven't made a PR since i don't have a Azure DevOps publisher account and all the other setup steps to test it ;)

kipusoep commented 5 months ago

No updates yet? We're having this issue as well and the result is that you're able to remove votes from someone else and 'steal' them to cast more votes. Really annoying.