search

microsoft / vsts-extension-retrospectives

An Azure DevOps extension for efficient retrospectives
MIT License
183 stars 82 forks source link

Voting - Pool control - decreasing other ones votes (arrow down) and use them as my owns to vote again (arrow up) #535

Open Blabladorro opened 1 year ago

Blabladorro commented 1 year ago

While voting any user can decrease the votes put on any feedback, even when they didn't vote for that particular feedback. It causes bias because

  1. The feedback got less votes it originally had
  2. As an user instead of have (ie.) 5 votes I got practically unlimited amount of votes.

Are you using the Retrospectives Tool on-prem? [ ] Yes [*] No

If Yes, what version of the extension?

To Reproduce Steps to reproduce the behavior:

  1. Perform a regular retro - gather at least 2 feedbacks.
  2. Vote on one of them and ask your colleague to vote for the other one.
  3. Using Arrow-down decrease the votes of your colleague of the feedback you didn't vote.
  4. Using Arrow-up assign newly gathered voting points to "your" feedback.
  5. The problem should be reproduced.

Expected behavior Not being able to decrease voting points on feedbacks you didn't vote. Not being able to exceed the number of votes you had originally.

Screenshots image

What screen type are you seeing this on ? [*] Desktop [ ] Mobile

Additional context N/A

ChenWenBrian commented 3 months ago

18 month after, this bug still exsit. 😂

A simple fix may work: when down-vote, check if the user have upvoted the item more than once, if not, down-vote failed, do nothing or prompt a warning. if yes, excute the current logic and reduce the upvote count.