microsoft / vsts-react-native-tasks

Streamline CI setup for your React Native app using a set of useful pre-defined build steps.
Other
30 stars 15 forks source link

Minor fixes: made two properties for bundle task required & fixed up a couple of error messages #17

Closed BretJohnson closed 8 years ago

msftclas commented 8 years ago

Hi @BretJohnson, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Bret Johnson). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

BretJohnson commented 8 years ago

@Chuxel - do you want to take a quick look at this

Chuxel commented 8 years ago

LGTM, and yes you are right. They were optional because of the Android use case when Prepare and Bundle were combined.