search

microsoft / vsts-vmware

17 stars 14 forks source link

waitForVMToBeDeployReady validation during snapshot restore #71

Open ghost opened 8 years ago

ghost commented 8 years ago

It looks like that currently your extension where reverting to certain snapshot is waiting for VM to come online to validate whether revert operation completed successfully. You basically use the same waitForVMToBeDeployReady function as in the case of PowerOn operation. This does not work for the scenario when your VM is turned off when snapshot was taken. I think the code should be checking whether the revert operation has completed successfully, instead of trying to discover that VM on the network. Does PowerCli and/or VMWare API allow you to do that?

mvvsubbu commented 7 years ago

You can set wait time for deployment ready state to be zero

image

mvvsubbu commented 7 years ago

Did this help? can you confirm?

mvvsubbu commented 7 years ago

Any update?

ghost commented 7 years ago

Setting timeout to 0 worked for me. Thank you.

I think though it's a workaround and not a permanent solution. What happens if reverting the snapshot takes a few seconds and I really do need that timeout?

On Wed, Dec 7, 2016 at 1:25 AM, Subrahmanyam Mandavilli < notifications@github.com> wrote:

Any update?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Microsoft/vsts-vmware/issues/71#issuecomment-265366545, or mute the thread https://github.com/notifications/unsubscribe-auth/APfbTsdSVFlZeL4L2-keMudWOlwPV5iQks5rFlFQgaJpZM4K78YG .

mvvsubbu commented 7 years ago

this timeout is not for revert snapshot operation, it is for waiting deployment readiness of the machine. So even if your snapshot revert takes more time task will wait for that, but it will not wait for deployment readiness.

derrix060 commented 5 years ago

It also worked for me. Please consider close this issue ;)