search

microsoft / vsts-zendesk-app

Visual Studio Team Services App for Zendesk
https://marketplace.visualstudio.com/items?itemName=ms-vsts.services-zendesk
MIT License
37 stars 31 forks source link

Cannot compile the source package #69

Closed andreaspfeiffer1131 closed 5 years ago

andreaspfeiffer1131 commented 6 years ago

Hi there,

I have implemented the previous version compatible with the zendesk framework 1. As it is not possible anymore to maintain this integration, I need to upgrade on a package compatible with zendesk framework 2.

Downloading and installing the compiled package available from the download page works fine. The issue is that I need to make few adaptations according to our zendesk (custom fields, change tag naming, etc..). In other words, I need to make some changes in the source app.js file, compile the package and upload it on our zendesk.

Here is what I made :

  1. download the source zip and unzip it
  2. do the following command : 
Andreass-MacBook-Pro-2:dist andreas$ pwd
/Users/andreas/Desktop/vsts-zendesk-app-0.6.2/dist
Andreass-MacBook-Pro-2:dist andreas$ zat validate
        info  Checking for new version of zendesk_apps_tools
/Users/andreas/.rvm/gems/ruby-2.5.1/gems/nokogiri-1.6.8.1/lib/nokogiri/xml/document.rb:44: warning: constant ::Fixnum is deprecated
    validate  Missing translation file for locale 'en'. Learn more: http://developer.zendesk.com/documentation/apps/i18n.html
    validate  assets/index.html is either an invalid location URI, refers to a missing asset, or does not use HTTPS.
Andreass-MacBook-Pro-2:dist andreas$
  1. In order to fix the missing translation file, I added it in the /dist folder translations/en.json (copy from folder /src)

Here is my result : 

Andreass-MacBook-Pro-2:dist andreas$ zat package
/Users/andreas/.rvm/gems/ruby-2.5.1/gems/nokogiri-1.6.8.1/lib/nokogiri/xml/document.rb:44: warning: constant ::Fixnum is deprecated
    validate  assets/index.html is either an invalid location URI, refers to a missing asset, or does not use HTTPS.
Andreass-MacBook-Pro-2:dist andreas$
  1. In order to fix the URI error, I added an empty index.html file in /dist/asset folder

the result looks now good : 

Andreass-MacBook-Pro-2:dist andreas$ 
Andreass-MacBook-Pro-2:dist andreas$ zat validate
/Users/andreas/.rvm/gems/ruby-2.5.1/gems/nokogiri-1.6.8.1/lib/nokogiri/xml/document.rb:44: warning: constant ::Fixnum is deprecated
    validate  OK
Andreass-MacBook-Pro-2:dist andreas$

And I can package the source folder either via the command zat package.

The issue is then that the apps do not display on zendesk after uploading it. I can only see the title and the logo.

I have try to take the index.html from the compile pack, but same result

What I am doing wrong ?

thank you for your help Andreas

andreaspfeiffer1131 commented 5 years ago

Hi there,

This issue can be closed. I managed to make my changes by unzipping the package (on files, issue was the \n against the \n with my code editor) then zipped package again and uploaded it !

thank you for this great apps Andreas