microsoft / wdkmetadata

Tooling to generate metadata for Win32 APIs in the Windows Driver Kit (WDK).
Other
96 stars 10 forks source link

NtCreateFile function enums #15

Closed AArnott closed 1 year ago

AArnott commented 1 year ago

The NtCreateFile method parameters could use some enum love:

See also discussion in microsoft/win32metadata#1440.

If NtCreateFile is in the WDK, it's already in the win32metadata, so... do we remove it, or fix the enums?

ChrisDenton commented 1 year ago

NtCreateFile is in both the WDK and the SDK. However, the WDK has more related definitions than the SDK.

mikebattista commented 1 year ago

Keeping this issue here since shared definitions should be consolidated into the SDK metadata.

kennykerr commented 1 year ago

I think we should remove this from the Win32 metadata and add it to the WDK metadata, since there are plenty other NtXxx APIs in the WDK but nothing comparable in the SDK. So the work here would be to remove it from this repo just as soon as the WDK repo add its, along with its friends.

mikebattista commented 1 year ago

I will transfer to wdkmetadata then and add a task to the item to remove it from the SDK before completing it.

kennykerr commented 1 year ago

So the function was removed from the win32 metadata and added to the wdk metadata? We'll need a matching release of both to avoid a missing function issue.