Closed AArnott closed 1 year ago
NtCreateFile
is in both the WDK and the SDK. However, the WDK has more related definitions than the SDK.
Keeping this issue here since shared definitions should be consolidated into the SDK metadata.
I think we should remove this from the Win32 metadata and add it to the WDK metadata, since there are plenty other NtXxx APIs in the WDK but nothing comparable in the SDK. So the work here would be to remove it from this repo just as soon as the WDK repo add its, along with its friends.
I will transfer to wdkmetadata then and add a task to the item to remove it from the SDK before completing it.
So the function was removed from the win32 metadata and added to the wdk metadata? We'll need a matching release of both to avoid a missing function issue.
The
NtCreateFile
method parameters could use some enum love:DesiredAccess
parameter is currently declared as uint, but it ought to be as thisFILE_ACCESS_FLAGS
enum.FileAttributes
parameter should be declared as a FILE_ATTRIBUTES enum. Previously suggested to beFILE_FLAGS_AND_ATTRIBUTES
but @KalleOlaviNiemitalo made a good comment in https://github.com/microsoft/win32metadata/issues/1440#issuecomment-1402709728 to consider.CreateOptions
(#1441)NtCreateFile
from the SDK metadata as part of this changeSee also discussion in microsoft/win32metadata#1440.
If
NtCreateFile
is in the WDK, it's already in the win32metadata, so... do we remove it, or fix the enums?