Invalid function imports

[kennykerr]

The latest build appears to include invalid function imports. Functions like:

[DllImport("CLFS", ExactSpelling = true, PreserveSig = false)]
public static extern void ClfsFinalize();

And also:

[DllImport("ksecdd", ExactSpelling = true, PreserveSig = false)]
public unsafe static extern SspiAsyncContext* SspiCreateAsyncContext();

To begin with, they lack a file extension so it's unclear how to link them.

Note that some of these may not even be DLLs to begin with (they may be .sys files) but I'm not sure how you determine that when generating the metadata.

Also, I though all library names should be lowercase but that doesn't appear to be enforced consistently across the Win32 and WDK metadata.

[riverar]

We closed the lowercase PR in favor of raw_dylib https://github.com/microsoft/win32metadata/issues/648. API to lib mappings is handled in libmappings.rsp and will need some corrections.

[mikebattista]

As @riverar said, libmappings.rsp is where these are defined.

7ab660565753342dd9f0d91737957c84692bdf62 was used to prepopulate this but the script and the output will need some scrutiny. The script was modified from the equivalent win32metadata script.

[mikebattista]

How should .exe., .drv, and .sys be handled? Should we just exclude those or can we support them?

[kennykerr]

They should work - we just need them to be explicit.

[mikebattista]

Thanks. It should be fixed now. Can you try it out first before I publish another release?

[kennykerr]

Thanks, checking now.

[kennykerr]

Yep, looks good - thanks!

[mikebattista]

Thanks. I published another update.