microsoft / webnn-developer-preview

MIT License
38 stars 7 forks source link

Fix #16 #17 Add outputDataType option for the ArgMax/ArgMin ops #19

Closed ibelem closed 1 month ago

ibelem commented 1 month ago

This PR included test packages of required WebNN EP fixes for #16 #17:

  1. https://github.com/microsoft/onnxruntime/pull/21385 Add outputDataType option for the ArgMax/ArgMin ops
  2. https://github.com/webmachinelearning/webnn/issues/629 argMax/Min only support scalar axis in TFLite runtime
  3. https://github.com/webmachinelearning/webnn/issues/652 ArgMax/Min selectLastIndex is not supported on CoreML
  4. Einsum for Segment Anything demo

Other changes:

  1. Removed powerPreference: "default" in application code since 353552552 (CL 5716629 will be landed later)
SD 1.5 SA
Chrome Canary 128.0.6612.0 Fail SAM ViT-B Decoder (FP16) Fail
Chrome Canary 128.0.6613.5 Fail SAM ViT-B Decoder (FP16) Fail
Chrome Dev 128.0.6601.2 Fail SAM ViT-B Decoder (FP16) Fail

The 5721028 fix is not in Canary 128.0.6613.5, need to wait new Canary build to test.

ibelem commented 1 month ago

The 129.0.6614.0 included the merged CL 5721028 - 128.0.6613.5 / 129.0.6614.0

SD 1.5 SA
Chrome Canary 128.0.6613.5 Fail SAM ViT-B Decoder (FP16) Fail
Chrome Canary 129.0.6614.0 PASS PASS

The SD Turbo (Text Encoder) mode failed to run with WebNN EP of ONNX Runtime Web 1.18 on the new 129.0.6614.0 build, so upgraded the EP to internal build for SD Turbo as well in 41f5e1e (#19). @miaobin @Honry

@fdwr PTAL

fdwr commented 1 month ago

PTAL

👀 Will before I leave today. Thank you Belem.

fdwr commented 1 month ago

Please do not merge this PR yet

Let me know when to merge it. (I moved the text buried in the middle of the text to the top of the description in case Adele tries to merge it).

ibelem commented 1 month ago

@fdwr It can be merged, as i've tested them pass on 129.0.6614.0 later yesterday. Thanks! @Adele101