microsoft / wil

Windows Implementation Library

MIT License

2.57k stars 234 forks source link

CreateFileW helpers are marked noexcept but throw #444

Closed ast-project-nd closed 3 months ago

ast-project-nd commented 4 months ago

The CreateFileW helpers in filesystem.h are marked noexcept but throw on error. This means that an error in any of these helpers will always cause std::terminate to be called. This affects the following functions:

open_file
create_new_file
open_or_create_file
open_or_truncate_existing_file
truncate_existing_file

dmachaj commented 4 months ago

@ChrisGuzak this seems to be related to #382. Can you please take a look when you are able?

ChrisGuzak commented 3 months ago

445

jonwis commented 3 months ago

Completed.