search

microsoft / wil

Windows Implementation Library
MIT License
2.57k stars 234 forks source link

try_open_file is part of WIL_ENABLE_EXCEPTIONS block #453

Open medarkmatter6 opened 1 month ago

medarkmatter6 commented 1 month ago

filesystem.h:1130

try_open_file does not throw exceptions as it returns a file+error result. But its disabled because it's inside the ifdef WIL_ENABLE_EXCEPTIONS.

Does this still throw or is this just a bug?

dunhor commented 1 month ago

From what I recall during PR discussion, @ChrisGuzak said that this was intentional

ChrisGuzak commented 1 month ago

does not throw. it could be moved out.

medarkmatter6 commented 1 month ago

Thanks for the responses! Sorry I should have contributed my own pr for this