RichEdit constants to enum

[elachlan]

There are several constants that would be nice to group to enums for ease of use/access.

Is the policy to leave constants alone for any values used for input/output to SendMessage?

These are a good example, where in winforms we limit private methods that call SendMessage with an enum.

• https://learn.microsoft.com/en-us/windows/win32/controls/em-streamout
• https://learn.microsoft.com/en-us/windows/win32/controls/em-streamin
• https://github.com/dotnet/winforms/blob/f59965e707d1a68bf381f59a721a97ff0c6fbcd2/src/System.Windows.Forms/src/System/Windows/Forms/RichTextBox.cs#L2985

Is this something win32metadata wants to do, or would you rather the constants?

Winforms Related: https://github.com/dotnet/winforms/issues/9823

[mikebattista]

Can you clarify what enums you want and where they would be applied or not?

[elachlan]

They are constants used in SendMessage, which means they wouldn't be applied to it. They would only be a grouping of constants.

• SF_*|SFF_* in one enum is an example.
• `SCF_*
• EN_*
• ENM_*
• ICM_* (we currently use one value so this isn't bad, but we had an enum defined with all values)

Edit: I can do the PR for it, but just wanted to check whether or not its something the team want.

[mikebattista]

Thanks. Creating enums to group them seems ok assuming that doesn't introduce any usability problems and only improves usability.

[elachlan]

@riverar would this cause problems for the rust projections?

[riverar]

@elachlan No problems anticipated. The Rust projection unpacks fictitious enums and emits constants. The names just need to remain unique both inside and outside the enum.

[mikebattista]

@elachlan are you still planning to tackle this?

[riverar]

Following up, @elachlan, is this still something you want to tackle?

[elachlan]

Happy to have someone else do it.