Open elachlan opened 11 months ago
Can you clarify what enums you want and where they would be applied or not?
They are constants used in SendMessage, which means they wouldn't be applied to it. They would only be a grouping of constants.
SF_*|SFF_*
in one enum is an example.EN_*
ENM_*
ICM_*
(we currently use one value so this isn't bad, but we had an enum defined with all values)Edit: I can do the PR for it, but just wanted to check whether or not its something the team want.
Thanks. Creating enums to group them seems ok assuming that doesn't introduce any usability problems and only improves usability.
@riverar would this cause problems for the rust projections?
@elachlan No problems anticipated. The Rust projection unpacks fictitious enums and emits constants. The names just need to remain unique both inside and outside the enum.
@elachlan are you still planning to tackle this?
Following up, @elachlan, is this still something you want to tackle?
Happy to have someone else do it.
There are several constants that would be nice to group to enums for ease of use/access.
Is the policy to leave constants alone for any values used for input/output to
SendMessage
?These are a good example, where in winforms we limit private methods that call SendMessage with an enum.
Is this something win32metadata wants to do, or would you rather the constants?
Winforms Related: https://github.com/dotnet/winforms/issues/9823