Open MarijnS95 opened 9 months ago
@MarijnS95 Did this one already get merged as part of a separate PR? If not, maybe a tiny one we can get in to close this out.
@riverar no it did not (and it took me to do a clean build in the target project to reproduce this). Will open a PR!
For https://github.com/Tsukisoft/direct-storage-rs/pull/5
We had a list of the form:
But no constants from
dstorageerr.h
were parsed. Swapping the filenames makes it so that#define
s fromdstorage.h
are lost, but defines fromdstorageerr.h
are parsed.I believe the raw string it's parsing here is:
dstorage.h;\ndstorageerr.h\n
, splitting this on;
causes the last filename to never match. Perhaps astring item = items[i].Trim();
is missing here to make multiline filename strings work more naturally?https://github.com/microsoft/win32metadata/blob/3d2ba1e501e46f078e4b4670a52ed68890870f8a/sources/GeneratorSdk/MetadataTasks/ScrapeHeaders.cs#L476-L488
After all, when merging this into one line:
Both files were finally parsed correctly.