search

microsoft / win32metadata

Tooling to generate metadata for Win32 APIs in the Windows SDK.
Other
1.34k stars 116 forks source link

Add references for all assemblies passed in via `--ref` #1886

Closed dpaoliello closed 5 months ago

dpaoliello commented 6 months ago

While trying to generate my own bindings, ClangSharpSourceToWinmd was reporting the following error:

error CS0648: '' is a type not supported by the language

I tracked it down to a method in the current compilation using a struct from a referenced WinMD (let's call this "Middle.winmd") which had a field from another WinMD (let's call it "Base.winmd"). Looking at the winmd files in ildasm, Middle.winmd was missing a reference to Base.winmd, so there was no way for the current compilation to know where referenced types came from, despite the current compilation referencing both Middle.winmd and Base.winmd.

The fix for this is to add an assembly reference to all assemblies passed in via --ref

kennykerr commented 5 months ago

@mikebattista?

mikebattista commented 5 months ago

Thanks for the contribution.

Our build and release pipelines are being refactored which is slowing things down. Once that's completed, we can resume updates.