search

microsoft / win32metadata

Tooling to generate metadata for Win32 APIs in the Windows SDK.
Other
1.32k stars 113 forks source link

NCRYPT_SSL_FUNCTION_TABLE/SslGetCipherSuitePRFHashAlgorithmFn doesn't exist #1925

Closed kennykerr closed 2 months ago

kennykerr commented 2 months ago

Hey Mike, just a heads up. I tested the latest build (from Azure) and there's a missing nested type, making the metadata unparseable.

The NCRYPT_SSL_FUNCTION_TABLE struct has a field called GetCipherSuitePRFHashAlgorithm whose type is SslGetCipherSuitePRFHashAlgorithmFn but that type is not defined anywhere.

kennykerr commented 2 months ago

Oh, might be related to #1914

riverar commented 2 months ago

Already fixed in https://github.com/microsoft/win32metadata/pull/1915 (code), so should be in next release.

riverar commented 2 months ago

Oh you're grabbing AzDo artifacts directly, strange. Should be in there if it's newer than 2 weeks.

kennykerr commented 2 months ago

Yep, its not fixed in latest build.

riverar commented 2 months ago

@mikebattista I excluded the original definition in the partition but it's also hitting on the manually defined function.

https://github.com/microsoft/win32metadata/blob/001243cda436f83ae72bdc940152f3d85da76698/generation/WinSDK/Partitions/Security.Cryptography/settings.rsp#L4-L7

Is there another workflow that excludes the function (as found in headers) and keeps the manual definition?

mikebattista commented 2 months ago

We just need to move the delegate definition up out of the Apis class. Working on it now.