search

microsoft / win32metadata

Tooling to generate metadata for Win32 APIs in the Windows SDK.
Other
1.34k stars 119 forks source link

PSID released multiple ways #1986

Closed AArnott closed 2 months ago

AArnott commented 2 months ago

The metadata documents that PSID should be released with FreeSid, which is sometimes appropriate as documented here.

But as @chrischu reports, ConvertStringSidToSid produces a PSID that should be released with LocalFree (go figure).

How can we get the metadata to reflect this?

Maybe we should just stop annotating on the PSID struct and leave it to users to read the docs and free appropriately. That would resolve #1985 too.