microsoft / win32metadata

Tooling to generate metadata for Win32 APIs in the Windows SDK.
Other
1.34k stars 118 forks source link

Missing IOCTL_CDROM_* constants #2018

Closed Stovent closed 1 week ago

Stovent commented 1 week ago

Summary

I noticed while trying to read from a CD drive that the IOCTLCDROM* constant for DeviceIoControl were missing in this crate, they do not show in the feature search page (version 0.58.0). I'm referring to those codes https://learn.microsoft.com/en-us/previous-versions/windows/drivers/storage/cd-rom-io-control-codes.

kennykerr commented 1 week ago

https://kennykerr.ca/rust-getting-started/how-are-crates-built.html

Will forward to the Win32 metadata repo.

riverar commented 1 week ago

Ideally you should use the IOCTL_STORAGE_* codes over IOCTL_CDROM_*. But yep, can confirm they're missing. We'll get them added.

riverar commented 1 week ago

@mikebattista I see you assigned yourself here, if you'd like can use my branch as a start rafael/additional-devices

mikebattista commented 1 week ago

Your changes look good. Basically what I started, but you're further ahead. I'll assign to you to finish up with a PR.

Stovent commented 1 week ago

Thank you for your quick response!

@kennykerr sorry to ping you but I'd like to know when this change will be available in windows-rs ? not necessarily a release but just a branch or commit I can use.

riverar commented 1 week ago

I can investigate that but we need a metadata release first.

mikebattista commented 1 week ago

There's a new win32metadata package on NuGet as of today just not yet a corresponding wdkmetadata package, if that helps you.

The wdkmetadata package will be released tomorrow if you want to wait.

Stovent commented 1 week ago

Thanks, I can wait it's for a personal project, I'm not in a hurry

riverar commented 6 days ago

@stovent You can wire up your project to the rafael/update-metadata branch on windows-rs. (After I update libs and pass some smoke tests.)

Stovent commented 6 days ago

Thank you very much! I've tested and it works