microsoft / windows-container-tools

Collection of tools to improve the Windows Containers experience
MIT License
240 stars 68 forks source link

Resolve versioning issue #146

Closed CharityKathure closed 1 year ago

CharityKathure commented 1 year ago

Issue: To support semantic versioning as outlined in https://semver.org, with format: MAJOR.MINOR.PATCH, the LM_BUILDMINORVERSION was made optional in the version header file, however it was left required in the LogMonitor.rc file.

image

Solution: Remove LM_BUILDMINORVERSION from LM_FULLVERSION_STR definition to comply with semantic versioning

Other Changes: For consistency with the semantic versioning as outlined in https://semver.org, LM_BUILDNUMBER was renamed to LM_PATCHNUMBER

After fix testing: image

How to test the fix:

  1. git fetch the changes
  2. Rebuild the solution,
  3. Using PowerShell: a) go to \windows-container-tools\LogMonitor\x64\Debug b)Run: (Get-Item .\LogMonitor.exe).VersionInfo | Format-List