Node.js script review - Githubissues

joaocgreis commented 6 years ago

Following https://github.com/Microsoft/windows-dev-box-setup-scripts/issues/12 (cc @gep13 @yodurr), I reviewed the Node.js script and added 4 commits:

Changed the Node.js package to install to LTS, it should be the default we recommend.
Removed Python 3 since the script is targeted at Node.js and node-gyp requires Python 2.
Added Visual Studio Build Tools to compile native modules (like in the Node.js Boxstarter script).
Added -y to all commands (this can be removed if it should be addressed elsewhere).

msftclas commented 6 years ago

All CLA requirements met.

yodurr commented 6 years ago

Thanks Bartosz!

microsoft / windows-dev-box-setup-scripts