microsoft / windows-dev-box-setup-scripts

Scripts to simplify setting up a Windows developer box
MIT License
1.76k stars 391 forks source link

Need to reboot after installing WSL #60

Closed yodurr closed 6 years ago

yodurr commented 6 years ago

Noticed we're not rebooting during script run, so the user has to reboot manually before they can run WSL.

yodurr commented 6 years ago

and if we reboot we need to prompt for password at the start of the script run...

yodurr commented 6 years ago

@mwrock for the reboot to work we need to cache the password right but we're currently running with the NoRestart flag probably because we never prompt for the password. How do we get a click-once based launch to also leverage restart and request the password?

mwrock commented 6 years ago

You just need to remove the /nr from the URL. Then the app should prompt and reboot if necessary.

yodurr commented 6 years ago

thanks. what if the user has a blank password? It looks like boxstarter doesn't like that answer in the password prompt. Known issue?

mwrock commented 6 years ago

not a known issue afaik but likely an issue that needs to be raised.

yodurr commented 6 years ago

Ok, we'll get the URI fixed here and submit a separate issue on boxstarter for blank password. Thanks.

yodurr commented 6 years ago

Addressed in commit #66