Fix windows store extension by upgrading dependencies

louis-wuitton commented 10 months ago

This pull request includes various changes to improve the codebase, simplify the code, and update dependencies. The most important changes include simplifying the code and improving readability in the gulpfile.js, updating the uploadZip function in apiHelper.ts to use the @azure/storage-blob package, and updating dependencies in package.json.

Main changes:

gulpfile.js: Simplified the code and improved readability by replacing multistream.apply with multidest, adding new tasks to remove the common directory and install node dependencies, and modifying the compile task to include the new tasks. [1] [2] [3] [4]
apiHelper.ts: Updated the uploadZip function to use the @azure/storage-blob package instead of the azure package. [1] [2] [3] [4]
package.json: Updated dependencies, including azure-pipelines-task-lib and @azure/storage-blob, and updated versions of url and uuid dependencies.

Other changes:

tasks/common/requestHelper.ts: Updated the import statement and usage of the uuid library. [1] [2]
tasks/store-flight/task.json: Added support for Node 10 and Node 16 in the store-flight task configuration and updated the Patch version. [1] [2]
vss-extension.json: Updated the version of the extension and changed the category.
tasks/common/apiHelper.ts: Updated import statements, removed typings references, and replaced the previous implementation of the uploadZip function. [1] [2] [3]
tasks/common/inputHelper.ts: Updated the import statement for the tl library.
tasks/store-publish/publishUi.ts: Updated the import statement for the tl library.
tasks/store-flight/flightUi.ts: Updated the import statement for the tl library.
tasks/store-publish/task.json: Updated the minimum agent version required and added new targets. [1] [2]
tasks/store-flight/flight.ts: Updated the import statement.
tasks/store-publish/publish.ts: Updated the import statement.

jamers99 commented 10 months ago

@louis-wuitton @junyin-ms hey guys! I'm getting this when using the Publish task! We can't use our pipelines for releases!

I've tried both MS-RDX-MRO.windows-store-publish.publish-task.store-publish@0 and store-publish@0

I'm guessing it's from the change in: tasks/store-publish/task.json

louis-wuitton commented 10 months ago

@louis-wuitton @junyin-ms hey guys! I'm getting this when using the Publish task! We can't use our pipelines for releases!

I've tried both MS-RDX-MRO.windows-store-publish.publish-task.store-publish@0 and store-publish@0

I'm guessing it's from the change in: tasks/store-publish/task.json

Thank you for catching this issue. I have added a hotfix to the extension and the storepublish task should be good now.

jamers99 commented 10 months ago

Perfect thanks! Verified the fix.

James Esh jamers99.com

From: Louis Wu @.> Sent: Friday, January 19, 2024 13:09 To: microsoft/windows-dev-center-vsts-extension @.> Cc: James Esh @.>; Comment @.> Subject: Re: [microsoft/windows-dev-center-vsts-extension] Fix windows store extension by upgrading dependencies (PR #105)

@louis-wuittonhttps://github.com/louis-wuitton @junyin-mshttps://github.com/junyin-ms hey guys! I'm getting this when using the Publish task! We can't use our pipelines for releases! [image] https://private-user-images.githubusercontent.com/20806279/298100799-1a9c9a92-e2f5-44e8-8635-21a706248984.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU2ODUyMjcsIm5iZiI6MTcwNTY4NDkyNywicGF0aCI6Ii8yMDgwNjI3OS8yOTgxMDA3OTktMWE5YzlhOTItZTJmNS00NGU4LTg2MzUtMjFhNzA2MjQ4OTg0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTE5VDE3MjIwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUyN2Y0NTMwNDkyMDAwMDcyYWZlMjc4NWYwMTIxNzczZjM5N2ZhYjRmYjQzOWNlZjQ1YzBlYjUxYjY0OTNiOTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.llAKAAd5VT1qjBUsgA52p3cQbXnPz_7BVx3-qveXK2g

I've tried both @. and @. [image] https://private-user-images.githubusercontent.com/20806279/298101622-f99be8e9-503a-49d1-98ee-87f9088b86d1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU2ODUyMjcsIm5iZiI6MTcwNTY4NDkyNywicGF0aCI6Ii8yMDgwNjI3OS8yOTgxMDE2MjItZjk5YmU4ZTktNTAzYS00OWQxLTk4ZWUtODdmOTA4OGI4NmQxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTE5VDE3MjIwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBjMjI5MWZjMzhlYzAyOGE2YTdiNzM0YjFjNGQzODBiYTk5YzhiMWY1NGZkZjY2ZTA0YTk2YTFmODI3ODA3Y2QmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.1wTCooW31gjhKfBgpN07j96t8IxuZf6Dhlg4EYryM-M

I'm guessing it's from the change in: tasks/store-publish/task.json

Thank you for catching this issue. I have added a hotfix to the extension and the storepublish task should be good now.

— Reply to this email directly, view it on GitHubhttps://github.com/microsoft/windows-dev-center-vsts-extension/pull/105#issuecomment-1900865969, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AE6XVB373JMTYMEGK23YPYLYPKZFXAVCNFSM6AAAAABBR6BC6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBQHA3DKOJWHE. You are receiving this because you commented.Message ID: @.***>

microsoft / windows-dev-center-vsts-extension

Fix windows store extension by upgrading dependencies #105