search

microsoft / windows-dev-center-vsts-extension

Visual Studio Team Services (VSTS) extension for performing continuous delivery to the Windows Dev Center store from your automated CI builds
Other
42 stars 17 forks source link

Allow to skip waiting for release after submit packages. #25

Closed vitaliy-leschenko closed 7 years ago

vitaliy-leschenko commented 7 years ago

Implementation of suggestion #23

msftclas commented 7 years ago

Hi @vlechenko, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

baumerik commented 7 years ago

Hi @vlechenko,

thanks for the implentation, but for implementing it with backwards compatibility would it be better to switch the bool parameter from waiting to a skip logic? Or is it equal and the build process handle it correctly?

vitaliy-leschenko commented 7 years ago

You are right. If change "waiting" default value to true then it will be fully backwards compatibility.

vitaliy-leschenko commented 7 years ago

Added new pull request #26 (with backwards compatibility)